Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Salmon index #211

Closed
wants to merge 10 commits into from
Closed

Add Salmon index #211

wants to merge 10 commits into from

Conversation

olgabot
Copy link
Contributor

@olgabot olgabot commented Jun 3, 2019 •
edited
Loading

Per @lpatano's suggestion, this PR adds just Salmon index. Discussed here: #171

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo (already done! nf-core/test-datasets@503c43c)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@olgabot olgabot mentioned this pull request Jun 3, 2019
Merged
8 tasks
@ewels ewels requested review from lpantano and kerimoff June 4, 2019 13:38
@lpantano
Copy link
Contributor

lpantano commented Jun 5, 2019

I close this since the code is duplicated in #212. Thanks @olgabot

@lpantano lpantano closed this Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpantano lpantano Awaiting requested review from lpantano

@kerimoff kerimoff Awaiting requested review from kerimoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgabot @lpantano